<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>



</head>
<body>
<style type="text/css">
img {
max-width: 100%; height: auto;
}
</style>
<div class="content">
<h3>
Imran Hussain pushed to branch sucs-site
at <a href="https://projects.sucs.org/sucssite/sucs-site">sucssite / sucs-site</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://projects.sucs.org/sucssite/sucs-site/commit/7eee2a8fb9959649af1e892975cfc85165889fcc">7eee2a8f</a></strong>
<div>
<span>by Imran Hussain</span>
<i>at 2016-10-13T14:14:45+01:00</i>
</div>
<pre class="commit-message" style="margin: 0; white-space: pre-wrap">Don't need to check if they aren't in the singup table if we know they aren't in the members table
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#diff-0" style="text-decoration: none">
components/susignup.php
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="diff-0">
<a href="https://projects.sucs.org/sucssite/sucs-site/commit/7eee2a8fb9959649af1e892975cfc85165889fcc#diff-0"><strong>components/susignup.php</strong></a>
<hr>
<table class="code white" style="-premailer-cellpadding: 0; -premailer-cellspacing: 0; -premailer-width: 100%; background: #fff; font-family: monospace; font-size: 13px" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" style="line-height: 1.5">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="52" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="52" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="background: #fafafa; color: rgba(0,0,0,0.3); padding-left: 0.5em; padding-right: 0.5em" bgcolor="#fafafa">@@ -52,7 +52,7 @@ if (!empty($_REQUEST['sid']) && !empty($_REQUEST['transactionID'])) {</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="52" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
52
</td>
<td class="diff-line-num new_line" data-linenumber="52" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
52
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC52" class="line">            <span class="nv" style="color: teal">$smarty</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">assign</span><span class="p">(</span><span class="s2" style="color: #d14">"id"</span><span class="p">,</span> <span class="nv" style="color: teal">$signuptmpresult</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">fields</span><span class="p">[</span><span class="s2" style="color: #d14">"id"</span><span class="p">]);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="53" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
53
</td>
<td class="diff-line-num new_line" data-linenumber="53" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
53
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC53" class="line">            <span class="nv" style="color: teal">$smarty</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">assign</span><span class="p">(</span><span class="s2" style="color: #d14">"pass"</span><span class="p">,</span> <span class="nv" style="color: teal">$signuptmpresult</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">fields</span><span class="p">[</span><span class="s2" style="color: #d14">"password"</span><span class="p">]);</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="54" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
54
</td>
<td class="diff-line-num new_line" data-linenumber="54" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
54
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC54" class="line">        <span class="c1" style="color: #998; font-style: italic">// else if they aren't in the SUCS DB, then bootstrap signup process</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" style="line-height: 1.5">
<td class="diff-line-num old old_line" data-linenumber="55" style="background: #f9d7dc; border-right-color: #fac5cd; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#f9d7dc">
55
</td>
<td class="diff-line-num new_line old" data-linenumber="55" style="background: #f9d7dc; border-right-color: #fac5cd; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#f9d7dc">
 
</td>
<td class="line_content noteable_line old" style="background: #fbe9eb; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#fbe9eb">
<pre style="margin: 0"> <span id="LC55" class="line">        <span class="p">}</span> <span class="k" style="font-weight: bold">else</span> <span class="k" style="font-weight: bold">if</span> <span class="p">(</span><span class="nv" style="color: teal">$tmpresult</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">fields</span> <span class="o" style="font-weight: bold">==</span> <span class="kc" style="font-weight: bold">false</span><span class="idiff left"> </span><span class="o" style="font-weight: bold"><span class="idiff">&&</span></span><span class="idiff"> </span><span class="nv" style="color: teal"><span class="idiff">$signuptmpresult</span></span><span class="o" style="font-weight: bold"><span class="idiff">-></span></span><span class="na" style="color: teal"><span class="idiff">fields</span></span><span class="idiff"> </span><span class="o" style="font-weight: bold"><span class="idiff">==</span></span><span class="idiff"> </span><span class="kc" style="font-weight: bold"><span class="idiff right">false</span></span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" style="line-height: 1.5">
<td class="diff-line-num new old_line" data-linenumber="56" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
 
</td>
<td class="diff-line-num new new_line" data-linenumber="55" style="background: #ddfbe6; border-right-color: #c7f0d2; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#ddfbe6">
55
</td>
<td class="line_content new noteable_line" style="background: #ecfdf0; padding-left: 0.5em; padding-right: 0.5em" bgcolor="#ecfdf0">
<pre style="margin: 0"> <span id="LC55" class="line">        <span class="p">}</span> <span class="k" style="font-weight: bold">else</span> <span class="k" style="font-weight: bold">if</span> <span class="p">(</span><span class="nv" style="color: teal">$tmpresult</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">fields</span> <span class="o" style="font-weight: bold">==</span> <span class="kc" style="font-weight: bold">false</span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="56" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
56
</td>
<td class="diff-line-num new_line" data-linenumber="56" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
56
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC56" class="line">            <span class="nv" style="color: teal">$mode</span> <span class="o" style="font-weight: bold">=</span> <span class="s2" style="color: #d14">"form"</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="57" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
57
</td>
<td class="diff-line-num new_line" data-linenumber="57" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
57
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC57" class="line">            <span class="nv" style="color: teal">$pass</span> <span class="o" style="font-weight: bold">=</span> <span class="nx">make_password</span><span class="p">();</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" style="line-height: 1.5">
<td class="diff-line-num old_line" data-linenumber="58" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
58
</td>
<td class="diff-line-num new_line" data-linenumber="58" style="background: #fafafa; border-right-color: #f0f0f0; border-right-style: solid; border-right-width: 1px; color: rgba(0,0,0,0.3); padding: 0 5px; text-align: right; width: 35px" align="right" bgcolor="#fafafa">
58
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em">
<pre style="margin: 0"> <span id="LC58" class="line">            <span class="nv" style="color: teal">$iddata</span> <span class="o" style="font-weight: bold">=</span> <span class="nv" style="color: teal">$sucsDB</span><span class="o" style="font-weight: bold">-></span><span class="na" style="color: teal">Execute</span><span class="p">(</span><span class="s2" style="color: #d14">"insert into signup (password,sid,issuedby) values( ?, ?, ?) returning id"</span><span class="p">,</span> <span class="k" style="font-weight: bold">array</span><span class="p">(</span><span class="nv" style="color: teal">$pass</span><span class="p">,</span> <span class="nv" style="color: teal">$sid</span><span class="p">,</span> <span class="s2" style="color: #d14">"99999"</span><span class="p">));</span></span>
</pre>
</td>
</tr>

</table>
<br>
</li>

</div>
<div class="footer" style="margin-top: 10px">
<p style="color: #777; font-size: small">

<br>
<a href="https://projects.sucs.org/sucssite/sucs-site/commit/7eee2a8fb9959649af1e892975cfc85165889fcc">View it on GitLab</a>.
<br>
You're receiving this email because of your account on projects.sucs.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://projects.sucs.org/sucssite/sucs-site/commit/7eee2a8fb9959649af1e892975cfc85165889fcc"}}</script>
</p>
</div>
</body>
</html>