<html lang='en'>
<head>
<meta content='text/html; charset=utf-8' http-equiv='Content-Type'>
<title>
GitLab
</title>
</meta>
</head>
<style>
img {
max-width: 100%;
height: auto;
}
p.details {
font-style:italic;
color:#777
}
.footer p {
font-size:small;
color:#777
}
pre.commit-message {
white-space: pre-wrap;
}
.file-stats a {
text-decoration: none;
}
.file-stats .new-file {
color: #090;
}
.file-stats .deleted-file {
color: #B00;
}
</style>
<body>
<div class='content'>
<h3>Tom Lake pushed to branch master at <a href="https://projects.sucs.org/arthur/mw">Justin Mitchell / mw</a></h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://projects.sucs.org/arthur/mw/commit/7ae988f2a7a9b551b8880a1fde0c6d0abe3843bd">7ae988f2</a></strong>
<div>
<span>by Thomas Lake</span>
<i>at 2016-01-22T23:39:42Z</i>
</div>
<pre class='commit-message'>Prevent transition to invalid room numbers from webclient</pre>
</li>
</ul>
<h4>2 changed files:</h4>
<ul>
<li class='file-stats'>
<a href='#diff-0'>
src/webclient/comms.c
</a>
</li>
<li class='file-stats'>
<a href='#diff-1'>
webclient/say.js
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id='diff-0'>
<a href='https://projects.sucs.org/arthur/mw/commit/7ae988f2a7a9b551b8880a1fde0c6d0abe3843bd#diff-0'>
<strong>
src/webclient/comms.c
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/src/webclient/comms.c
</span><span style="color: #000000;background-color: #ddffdd">+++ b/src/webclient/comms.c
</span><span style="color: #aaaaaa">@@ -407,6 +407,10 @@ static int handle_command(CONNECTION *co)
</span> user->record.idletime = lastcomm;
if (newroom == oldroom) {
return 1;
<span style="color: #000000;background-color: #ddffdd">+ }else if (newroom<0 || newroom>65535) {
+ snprintf(line, sizeof line, "\03314Not leaving to invalid room ID %d", newroom);
+ ipc_send_to_username(user->record.name, IPC_TEXT, line);
+ return 1;
</span> }else{
user->record.room = newroom;
snprintf(line, sizeof line, "\03313%s has left to room %d", user->record.name, newroom);
</code></pre>
<br>
</li>
<li id='diff-1'>
<a href='https://projects.sucs.org/arthur/mw/commit/7ae988f2a7a9b551b8880a1fde0c6d0abe3843bd#diff-1'>
<strong>
webclient/say.js
</strong>
</a>
<hr>
<pre class="highlight"><code><span style="color: #000000;background-color: #ffdddd">--- a/webclient/say.js
</span><span style="color: #000000;background-color: #ddffdd">+++ b/webclient/say.js
</span><span style="color: #aaaaaa">@@ -245,7 +245,7 @@ function cmdParser(text) {
</span> sendCmdHandle('who', drawWho);
break;
case "room":
<span style="color: #000000;background-color: #ffdddd">- if (args == undefined){
</span><span style="color: #000000;background-color: #ddffdd">+ if (args == undefined || args < 0 || args > 65535){
</span> $('#textlist').append("<div class='error'>Usage: "+cmd+" <number></div>");
}else{
sendCmd('channel '+args);
</code></pre>
<br>
</li>
</div>
<div class='footer' style='margin-top: 10px;'>
<p>
—
<br>
<a href="https://projects.sucs.org/arthur/mw/commit/7ae988f2a7a9b551b8880a1fde0c6d0abe3843bd">View it on GitLab</a>.
<br>
You're receiving this email because of your account on projects.sucs.org.
If you'd like to receive fewer emails, you can adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://projects.sucs.org/arthur/mw/commit/7ae988f2a7a9b551b8880a1fde0c6d0abe3843bd"}}</script>
</p>
</div>
</body>
</html>