[SUCS Devel] [Git][sucssite/sucs-site][master] Make signup send one email, and fix some grammar that has been annoying me since I joined

[Laurence Sebastian Bowes]

Laurence Sebastian Bowes pushed to branch master at sucssite / sucs-site


Commits:
9fa6882d by Laurence Sebastian Bowes at 2018-11-21T14:39:07+00:00
Make signup send one email, and fix some grammar that has been annoying me since I joined
- - - - -


1 changed file:

- components/signup.php


Changes:

=====================================
components/signup.php
=====================================
--- a/components/signup.php
+++ b/components/signup.php
@@ -167,7 +167,7 @@ if (isset($_REQUEST['signupid']) && isset($_REQUEST['signuppw'])) {
                                 mail(
                                     $error_email,
                                     "Signup Error",
-                                    "User " . $fields['username'] . " already exists in the databse, THIS SHOULD NEVER HAPPEN\n Love the signup system.\n\nP.S. the signup id is: " . $signupid,
+                                    "User " . $fields['username'] . " already exists in the database, THIS SHOULD NEVER HAPPEN\n Love, the signup system.\n\nP.S. the signup id is: " . $signupid,
                                     "From: \"SUCS Admin\" <admin at sucs.org>"
                                 );
                                 $failed = true;
@@ -251,16 +251,10 @@ if (isset($_REQUEST['signupid']) && isset($_REQUEST['signuppw'])) {
                                     if ($override) {
                                         $logsmessage .= "User " . $session->username . " overrode validation.\n";
                                     }
-                                    $logsmessage .= "Love The Signup System";
+                                    $logsmessage .= "Love, The Signup System";
                                     // DEV: CHANGE THIS EMAIL ADDRESS
                                     mail(
-                                        "logs at sucs.org",
-                                        "User '" . $fields['username'] . "' Created on SUCS",
-                                        $logsmessage,
-                                        "From: \"SUCS Admin\" <admin at sucs.org>"
-                                    );
-                                    mail(
-                                        "treasurer at sucs.org",
+                                        "logs at sucs.org,treasurer at sucs.org",
                                         "User '" . $fields['username'] . "' Created on SUCS",
                                         $logsmessage,
                                         "From: \"SUCS Admin\" <admin at sucs.org>"
@@ -335,7 +329,7 @@ if (isset($_REQUEST['signupid']) && isset($_REQUEST['signuppw'])) {
                         foreach ($errorreparray as $key => $value) {
                             $errorreport .= $key . ": " . $value . "\n";
                         }
-                        $errorreport .= "\nLove from the Signup System";
+                        $errorreport .= "\nLove, the Signup System";
                         mail(
                             $error_email,
                             "Signup system error report",



View it on GitLab: https://projects.sucs.org/sucssite/sucs-site/commit/9fa6882df44d3e6f1ecf9f0bbe8c31132df36c37

-- 
View it on GitLab: https://projects.sucs.org/sucssite/sucs-site/commit/9fa6882df44d3e6f1ecf9f0bbe8c31132df36c37
You're receiving this email because of your account on projects.sucs.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sucs.org/pipermail/devel/attachments/20181121/dafdcb79/attachment-0001.html>