[mw-devel] [Git][arthur/mw][master] 2 commits: Address sanitizer fixups

Andrew Price welshbyte at sucs.org
Mon Aug 14 13:07:56 BST 2017


On Mon, Aug 14, 2017 at 10:08:32AM +0100, Justin Mitchell wrote:
> On Sun, 2017-08-13 at 19:16 +0100, Andrew Price wrote:
> > src/socket.c
> > @@ -134,7 +134,7 @@ int ipcconn_connect(const char * target)
> Could just be a strdupa() instead ?

Yup. Although, that function technically doesn't need to allocate new memory for the host and port at all. It shouldn't be parsing a command line argument there. I'll tweak it so it can just pass in the port and host separately as pointers into the argv string.

Andy



More information about the mw-devel mailing list