[mw-devel] [Git][milliways/mw][master] Fix #12: ignore the old protection flags in favour for the new system

Andrew Price welshbyte at sucs.org
Wed Oct 9 16:46:34 BST 2019


On 09/10/2019 16:05, Imran Hussain wrote:
> On 2019-10-09 15:53, Andrew Price wrote:
>> On 08/10/2019 12:19, Imran Hussain wrote:
>> Do, or do not, there is no commented-out.
> 
> When someone rips it out completely they can remove it, but I wanted to 
> add meaningful comments to something that isn't quite disabled but 
> ignored :)

A meaningful comment explains why the current implementation is the way 
it is, independent of the previous implementation. Otherwise it's a 
higher barrier to entry for new contributors and anyone who doesn't 
understand the old implementation (e.g. me).

Andy



More information about the mw-devel mailing list